Skip to content

chore: add missing changelog entry about a fix from elastic-agent-libs#42804

Merged
mauri870 merged 11 commits intoelastic:mainfrom
mauri870:bump-libs
Mar 10, 2025
Merged

chore: add missing changelog entry about a fix from elastic-agent-libs#42804
mauri870 merged 11 commits intoelastic:mainfrom
mauri870:bump-libs

Conversation

@mauri870
Copy link
Member

@mauri870 mauri870 commented Feb 20, 2025 •
edited
Loading

Proposed commit message

Elastic Agent libs v0.18.7 included a fix to rotate a file when the destination is a symbolic link. This PR adds a changelog entry for the fix.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@mauri870 mauri870 self-assigned this Feb 20, 2025
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 20, 2025
@mauri870 mauri870 added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 20, 2025
@mergify
Copy link
Contributor

mergify bot commented Feb 20, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @mauri870? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@mauri870 mauri870 added backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch labels Feb 20, 2025
@mauri870
Copy link
Member Author

mauri870 commented Feb 21, 2025

Test failures are related to a breaking change in libs.
Fixed in elastic/elastic-agent-libs#283.

@mauri870 mauri870 force-pushed the bump-libs branch 2 times, most recently from 2ccca1f to b9fabb1 Compare February 24, 2025 11:16
@mauri870 mauri870 mentioned this pull request Feb 28, 2025
Closed
6 tasks
@mauri870 mauri870 marked this pull request as ready for review February 28, 2025 19:51
@mauri870 mauri870 requested a review from a team as a code owner February 28, 2025 19:51
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 28, 2025

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@mauri870 mauri870 requested a review from a team as a code owner February 28, 2025 20:06
@cmacknz cmacknz added backport-active-8 Automated backport with mergify to all the active 8.[0-9]+ branches and removed backport-8.x Automated backport to the 8.x branch with mergify labels Feb 28, 2025
@strawgate
Copy link
Contributor

strawgate commented Mar 1, 2025

@mauri870 I have merged a change to agent-libs for improved warning logging during SSL handling that I would love backported as well, would you be open to carving a version that includes elastic/elastic-agent-libs#285 (already merged) and bumping to that version in this PR? So that we avoid doing bumping + backports twice for the lib update

@mauri870
Copy link
Member Author

mauri870 commented Mar 5, 2025

/test

@mauri870 mauri870 changed the title chore: update elastic-agent-libs chore: update elastic-agent-libs to v0.18.8 Mar 5, 2025
@cmacknz
Copy link
Member

cmacknz commented Mar 5, 2025

Thanks, will approve once CI is passing.

@mauri870
Copy link
Member Author

mauri870 commented Mar 6, 2025

Thanks, will approve once CI is passing.

I finally got a green CI! Just waiting on your approval. Thanks!

@mauri870 mauri870 enabled auto-merge (squash) March 7, 2025 14:39
@mauri870 mauri870 changed the title chore: update elastic-agent-libs to v0.18.8 chore: add missing changelog entry about a fix from elastic-agent-libs Mar 10, 2025
@mauri870
Copy link
Member Author

mauri870 commented Mar 10, 2025

Unfortunately, another PR first bumped the libs to v0.18.9 at #43106. The diff now only shows the changelog entry. I think we can merge it as is, and for the backports, I will ensure we have the up-to-date version of the library.

@mauri870 mauri870 dismissed cmacknz’s stale review March 10, 2025 12:41

Moved the changelog to the right place.

rdner
rdner approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@rdner rdner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message should have a reference to the actual library bump and clearly described as a follow up.

I think it's good to have this changelog entry.

@mauri870 mauri870 merged commit d1450fa into elastic:main Mar 10, 2025
11 checks passed
mergify bot pushed a commit that referenced this pull request Mar 10, 2025
@mauri870 @mergify
chore: update elastic-agent-libs to v0.18.8 (#42804)
a38df70 
* chore: update elastic-agent-libs

* add changelog

* fix changelog entry

(cherry picked from commit d1450fa)
@mergify mergify bot mentioned this pull request Mar 10, 2025
Merged
6 tasks
mergify bot pushed a commit that referenced this pull request Mar 10, 2025
@mauri870 @mergify
chore: update elastic-agent-libs to v0.18.8 (#42804)
4a23c5b 
* chore: update elastic-agent-libs

* add changelog

* fix changelog entry

(cherry picked from commit d1450fa)
@mergify mergify bot mentioned this pull request Mar 10, 2025
Merged
6 tasks
mergify bot pushed a commit that referenced this pull request Mar 10, 2025
@mauri870 @mergify
chore: update elastic-agent-libs to v0.18.8 (#42804)
6863c07 
* chore: update elastic-agent-libs

* add changelog

* fix changelog entry

(cherry picked from commit d1450fa)
@mergify mergify bot mentioned this pull request Mar 10, 2025
Merged
6 tasks
mergify bot pushed a commit that referenced this pull request Mar 10, 2025
@mauri870 @mergify
chore: update elastic-agent-libs to v0.18.8 (#42804)
903be0a 
* chore: update elastic-agent-libs

* add changelog

* fix changelog entry

(cherry picked from commit d1450fa)
@mergify mergify bot mentioned this pull request Mar 10, 2025
Merged
6 tasks
mergify bot pushed a commit that referenced this pull request Mar 10, 2025
@mauri870 @mergify
chore: update elastic-agent-libs to v0.18.8 (#42804)
e277088 
* chore: update elastic-agent-libs

* add changelog

* fix changelog entry

(cherry picked from commit d1450fa)
@mergify mergify bot mentioned this pull request Mar 10, 2025
Merged
6 tasks
mauri870 added a commit that referenced this pull request Mar 10, 2025
@mergify @mauri870
[8.x](backport #42804) chore: add missing changelog entry about a fix…
349dcbd 
… from elastic-agent-libs (#43141)

* chore: update elastic-agent-libs to v0.18.8 (#42804)

* chore: update elastic-agent-libs

* add changelog

* fix changelog entry

(cherry picked from commit d1450fa)

* update changelog

---------

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
mauri870 added a commit that referenced this pull request Mar 10, 2025
@mergify @mauri870
[9.0](backport #42804) chore: add missing changelog entry about a fix…
8a77b0c 
… from elastic-agent-libs (#43140)

* chore: update elastic-agent-libs to v0.18.8 (#42804)

* chore: update elastic-agent-libs

* add changelog

* fix changelog entry

(cherry picked from commit d1450fa)

* fix changelog

---------

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
mauri870 added a commit that referenced this pull request Mar 10, 2025
@mergify @mauri870
[8.18](backport #42804) chore: add missing changelog entry about a fi…
22014f6 
…x from elastic-agent-libs (#43142)

* chore: update elastic-agent-libs to v0.18.8 (#42804)

* chore: update elastic-agent-libs

* add changelog

* fix changelog entry

(cherry picked from commit d1450fa)

* tidy changelog

---------

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
mauri870 added a commit that referenced this pull request Mar 10, 2025
@mergify @mauri870
[8.17](backport #42804) chore: add missing changelog entry about a fi…
9a7c8e6 
…x from elastic-agent-libs (#43143)

* chore: update elastic-agent-libs to v0.18.8 (#42804)

* chore: update elastic-agent-libs

* add changelog

* fix changelog entry

(cherry picked from commit d1450fa)

* tidy changelog

---------

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
mauri870 added a commit that referenced this pull request Mar 10, 2025
@mergify @mauri870
[8.16](backport #42804) chore: add missing changelog entry about a fi…
1698c25 
…x from elastic-agent-libs (#43144)

* chore: update elastic-agent-libs to v0.18.8 (#42804)

* chore: update elastic-agent-libs

* add changelog

* fix changelog entry

(cherry picked from commit d1450fa)

* tidy changelog

---------

Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdner rdner rdner approved these changes

@AndersonQ AndersonQ Awaiting requested review from AndersonQ AndersonQ was automatically assigned from elastic/elastic-agent-data-plane

@VihasMakwana VihasMakwana Awaiting requested review from VihasMakwana VihasMakwana was automatically assigned from elastic/elastic-agent-data-plane

@cmacknz cmacknz Awaiting requested review from cmacknz

Assignees

@mauri870 mauri870

Labels

backport-9.0 Automated backport to the 9.0 branch backport-active-8 Automated backport with mergify to all the active 8.[0-9]+ branches cleanup Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mauri870 @elasticmachine @strawgate @cmacknz @rdner